chore: run eas only when labelled#3208
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
github-actions
Bot
added
vouch:trusted
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit f15d829. Configure here.
| jobs: | ||
| preview: | ||
| name: EAS Preview | ||
| if: contains(github.event.pull_request.labels.*.name, 'mobile-build') |
There was a problem hiding this comment.
Label churn retriggers EAS preview
High Severity
The workflow triggers on labeled and unlabeled events. The job runs if the mobile-build label is present, causing redundant EAS preview deploys when other labels change (e.g., automated size:* updates), even without new code. This increases run time and resource usage.
Reviewed by Cursor Bugbot for commit f15d829. Configure here.
![macroscopeapp[bot]](https://avatars.githubusercontent.com/in/900172?s=60&v=4){kind=small}
ApprovabilityA prior Macroscope approval was dismissed. Re-evaluating 191eb3d… |
Yash-Singh1
force-pushed
the
yash/run-eas-labelled
branch
from
f15d829 to
191eb3d
Compare
macroscopeapp
Bot
dismissed
their stale review
Dismissing prior approval to re-evaluate 191eb3d
|
🚀 Expo continuous deployment is ready!
|
2 participants
What Changed
Why
UI Changes
Checklist
Note
Low Risk
CI-only workflow gating with no application, auth, or data-path changes.
Overview
EAS Preview no longer runs on every pull request. The
mobile-eas-previewworkflow still listens to PR activity, but the preview job is skipped unless the PR carries the🚀 Mobile Continuous Deploymentlabel.The workflow now declares explicit
pull_requesttypes (opened,reopened,synchronize,labeled,unlabeled) so adding or removing that label re-triggers the workflow and theifcondition is evaluated again—e.g. a label added after open can start a build without a new push.Reviewed by Cursor Bugbot for commit 191eb3d. Bugbot is set up for automated code reviews on this repo. Configure here.
Note
Run EAS preview job only when PR has the Mobile CD label
The
previewjob in mobile-eas-preview.yml now requires the🚀 Mobile Continuous Deploymentlabel to run. The workflow also addslabeledandunlabeledto its trigger events so the condition is evaluated when labels change.Macroscope summarized 191eb3d.